Fix Social SDK leaving lobby #7540
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Totally off the top of my head: // Leaving a lobby from the client
uint64_t lobbyId = 01234567890;
client->LeaveLobby(lobbyId, [&](discordpp::ClientResult result) {
if(result.Successful()) {
std::cout << "🎮 Left lobby successfully! Lobby Id: " << lobbyId << std::endl;
} else {
std::cerr << "❌ Leaving lobby failed\n";
}
}But I think that will work, and you can see it get passed through? WDYT? |
|
I like it. In this case, I could also change the example from Sending Messages to a Lobby to match it: uint64_t lobbyId = 01234567890;
client->SendLobbyMessage(lobbyId, "Hello", [](discordpp::ClientResult result, uint64_t messageId) {
if(result.Successful()) {
std::cout << "📨 Message sent successfully!\n";
} else {
std::cerr << "❌ Message sending failed\n";
}
});Note: can I also add a space between creating variable and the function calling? |
|
Sure - that works for me 👍🏻 sounds good! No concerns on extra line break 😄 |
|
Done 👍 |
markmandel
approved these changes
May 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the section Managing Lobbies, the code for Leaving a Lobby:
Mention a
uint64_t lobbyIdwhich doesn't seem to exist inLeaveLobbyCallback.I was thinking in changing the example to: